Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[LICENSE] updated licenses for files under both ASF + BSD 3-clause #20495

Merged
merged 10 commits into from
Aug 13, 2021
Merged

[LICENSE] updated licenses for files under both ASF + BSD 3-clause #20495

merged 10 commits into from
Aug 13, 2021

Conversation

hongshanli23
Copy link
Contributor

@hongshanli23 hongshanli23 commented Aug 7, 2021 •
edited
Loading

Description

This PR is for item 4 in #20475

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Removed ASF header for files with no significant code changes (FindJeMalloc.cmake, mkldnn_base-inl.h)
  • Moved files under both ASF + BSD 3-clause to the correct section in LICENSE

@hongshanli23 hongshanli23 requested a review from szha as a code owner August 7, 2021 00:07
@mxnet-bot
Copy link

Hey @hsl89 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, website, centos-cpu, unix-gpu, sanity, miscellaneous, windows-gpu, unix-cpu, edge, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 7, 2021
@TristonC
Copy link
Contributor

TristonC commented Aug 9, 2021

@hsl89 , A side note: If you put x instead of Y in the Essentials and Changes' list (like [x]), it will show a check mark there.

@hongshanli23
Copy link
Contributor Author

@hsl89 , A side note: If you put x instead of Y in the Essentials and Changes' list (like [x]), it will show a check mark there.

magic

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 9, 2021
josephevans
josephevans reviewed Aug 9, 2021
View reviewed changes
src/operator/nn/mkldnn/mkldnn_base-inl.h Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 9, 2021
@josephevans
Copy link
Contributor

Also noticed that FindJeMalloc.cmake is failing the license check as well, since license_header.py doesn't recognize the Boost license. Can you also add this to the same whitelist?

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 10, 2021
@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Aug 11, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 11, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 12, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 13, 2021
josephevans
josephevans approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 13, 2021
@josephevans josephevans merged commit 1716402 into apache:v1.9.x Aug 13, 2021
@josephevans
Copy link
Contributor

@hsl89 Can you please port this to v1.x and master branches? Thanks!

@hongshanli23 hongshanli23 mentioned this pull request Aug 19, 2021
Merged
4 tasks
barry-jin pushed a commit to barry-jin/incubator-mxnet that referenced this pull request Sep 24, 2021
@hongshanli23 @barry-jin
Port apache#20495
3bf4b4e
@barry-jin barry-jin mentioned this pull request Sep 24, 2021
Merged
4 tasks
barry-jin added a commit that referenced this pull request Sep 28, 2021
@barry-jin @hongshanli23
Port #20495 (#20607)
88f6cc4 
Co-authored-by: Hongshan Li <lihongshan8128@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@josephevans josephevans josephevans approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hongshanli23 @mxnet-bot @TristonC @josephevans @leezu @mseth10 @aws-tensorflow-bot